IVY-1280 Support preemptive authentication #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I didn't push it upstream because of this open point: tt-gf#2 (comment) So this might break some authentication schemes, I'm not really sure. EDIT: we have been using it at TomTom for a while, but we use only the Basic auth scheme. |
Contributor
Author
|
I have noticed that. Perhaps it's enough to document that preemptive authentication only works with basic scheme. |
Contributor
Author
|
Looking at examples, digest authentication uses the same cache, only sets a different scheme. |
twogee
force-pushed
the
ivy-1280
branch
2 times, most recently
from
18c4efc to
a9139f0
Compare
twogee
force-pushed
the
ivy-1280
branch
4 times, most recently
from
279cacf to
6745ae2
Compare
Contributor
Author
|
I would like to add the preemptive authentication flag to the newly minted |
Contributor
Author
|
@AurelienLourot we moved the discussion to JIRA |
twogee
force-pushed
the
ivy-1280
branch
2 times, most recently
from
c3a96eb to
909b7a4
Compare
twogee
force-pushed
the
ivy-1280
branch
2 times, most recently
from
6d1265a to
b18a58b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adopted a patch by @AurelienLourot