-
Notifications
You must be signed in to change notification settings - Fork 111
IVY-1321 Make Main.run() public #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This addresses IVY-1321 and IVY-1578 |
I agree @twogee now that I've seen your change, your solution would be better. Now perhaps these https://www.google.com/search?q=ivy+programmatic+stackoverflow
Thanks. |
Actually, you should be able to do
But, I was hasty and the tests still fail. I'll try to rectify that later today. |
I'm a bit surprised that StackOverflow does not refer to Apache Confluence |
a644bc1
to
3f77855
Compare
@supertick if you're fine with this PR, please close #69. I will merge this one later. |
I would make a default overload which took only a String[] arg to model exactly the Main.main input, but all the rest is perfect, including the better isCli boolean vs silly cli option ResolveReport report = Main.run(new String[]{ .... exact standalone api ... }) I would leave the Exception throws signature in the overloaded run method... Thanks for your consideration, work, and mention ;) ! |
Thanks for bearing with me 😉please see the revised commit. |
Looks great ! |
Inspired by #69