-
Notifications
You must be signed in to change notification settings - Fork 581
feat: e2e workflow, auth test #3050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds end-to-end testing capabilities using Playwright by introducing a dedicated configuration, test specs, supporting utilities, and CI/CD workflow enhancements. Key changes include the addition of a new tsconfig for e2e tests, updates to package.json and ESLint configuration to support testing/linting of e2e files, and various Docker and GitHub workflow files to run the tests in CI.
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.e2e.json | New TS configuration for e2e test files |
| tsconfig.app.json | Updated to include specific e2e utility file |
| src/components/form/Btn.tsx | Updated component type signature with polymorphic props |
| playwright.config.ts | Added Playwright configuration for e2e testing |
| package.json | Updated scripts and dependencies to support e2e testing and linting |
| eslint.config.js | Merged ESLint rules including new e2e rules |
| e2e/utils/*.ts | New utilities and test setup for e2e testing |
| e2e/server/*.yml, Dockerfile | New server configuration files for running the test dashboard |
| e2e/auth.spec.ts | New authentication test spec using Playwright |
| .github/workflows/e2e.yml | New GitHub Action workflow to run the e2e test suite |
| .devcontainer/*.yml, devcontainer.json | Updated devcontainer configuration to integrate e2e services |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| viewport: { width: 1920, height: 1080 }, | ||
| permissions: ['clipboard-read'], | ||
| // use chrome | ||
| // channel: "chrome", |
Copilot
AI
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider removing or clarifying the commented-out 'channel: "chrome"' configuration if it is no longer needed.
| // channel: "chrome", |
| export default tseslint.config( | ||
| { ignores: ['dist', 'src/routeTree.gen.ts'] }, | ||
| e2eRules, |
Copilot
AI
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Review the merge order of the e2eRules configuration with the main ESLint settings to ensure there are no unintended overrides. Clarifying the configuration merge could improve maintainability.
| export default tseslint.config( | |
| { ignores: ['dist', 'src/routeTree.gen.ts'] }, | |
| e2eRules, | |
| export const e2eRulesConfig = e2eRules; | |
| export default tseslint.config( | |
| { ignores: ['dist', 'src/routeTree.gen.ts'] }, |
juzhiyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
e2e-testauth.spec.tsto help check if the workflow worksAlso working fine locally