Skip to content

Conversation

@SkyeYoung
Copy link
Member

@SkyeYoung SkyeYoung commented May 14, 2025

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

According to #3042 (comment), proposed in a separate PR

including i18n and quotes rules.

@SkyeYoung SkyeYoung changed the title chore(eslint): add i18n, quotes rules chore(eslint): improve i18n, quotes rules May 14, 2025
@SkyeYoung SkyeYoung changed the title chore(eslint): improve i18n, quotes rules chore: improve eslint rules and format May 14, 2025
@SkyeYoung SkyeYoung marked this pull request as ready for review May 14, 2025 02:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the project's ESLint configuration by updating rules and adding new plugins for i18n and quotes enforcement. Key changes include:

  • Replacement of template literal notation with single quotes in the global store's set function.
  • Addition of new ESLint plugins and rules for i18n and code style in package.json and eslint.config.ts.
  • Removal of the old eslint.config.js in favor of the new TypeScript-based configuration.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/stores/global.ts Updated key parameter syntax for consistency
package.json Added new dependencies for ESLint i18n and quotes support
eslint.config.ts Introduced a new, comprehensive ESLint configuration
eslint.config.js Removed in favor of the new TypeScript configuration
Comments suppressed due to low confidence (1)

eslint.config.ts:84

  • Verify that the interpolationPattern '{.+}' matches the intended interpolation expressions, as the current regex may not correctly capture the desired patterns.
{ interpolationPattern: '\{\.+\}' },

@SkyeYoung SkyeYoung merged commit c8c809c into apache:master May 14, 2025
5 checks passed
@SkyeYoung SkyeYoung deleted the young/chore/eslint-i18n-quotes-rules branch May 14, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants