Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary rockspec files #10441

Conversation

monkeyDluffy6017
Copy link
Contributor

@monkeyDluffy6017 monkeyDluffy6017 commented Nov 3, 2023

Description

The rockspec files are unnecessary, we can keep one rockspec file in every branch.
For example, we keep the apisix-master-0.rockspec file in the master branch and keep the apisix-3.6.0-0.rockspec file in release/3.6.0 branch

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

moonming
moonming previously approved these changes Nov 3, 2023
Copy link
Contributor

@Revolyssup Revolyssup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the path reference to master rockspec.

@monkeyDluffy6017
Copy link
Contributor Author

hi @Revolyssup the ci won't pass because i change the file path
image

@monkeyDluffy6017 monkeyDluffy6017 merged commit a440912 into apache:master Dec 5, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants