Skip to content

Conversation

@shreemaan-abhishek
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek commented Sep 12, 2024

Description

foo.com used in traffic split test is a valid domain now and sending plain http request will yield 302 status code instead of 502.
https://github.com/apache/apisix/actions/runs/10823712557/job/30029684940?pr=11499#step:21:380

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. CI labels Sep 12, 2024
@bzp2010
Copy link
Contributor

bzp2010 commented Sep 12, 2024

Can we change that domain to something that can't possibly exist?
For example using a non-existent TLD like foo.local, which would not exist on any well known DNS, or even, we could leave the suffix alone.

@shreemaan-abhishek shreemaan-abhishek merged commit b37ae50 into apache:master Sep 12, 2024
30 of 31 checks passed
@shreemaan-abhishek shreemaan-abhishek deleted the fix-tfsp-test branch September 12, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants