Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ip-restriction): support 404 response code #12076

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(ip-restriction): support 404 response code #12076

wants to merge 1 commit into from
+105 −7

Conversation

papdaniel
Copy link

Description

Support 404 response code to hide the route from blacklisted/not whitelisted sources

Fixes # (12056)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Mar 21, 2025
@papdaniel
Copy link
Author

I think making response code configurable to 404 is enough. Should we support any response codes, or any 4xx codes?

@Baoyuantop
Copy link
Contributor

Personally I think any 4xx code should be configurable, looking forward to other more comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@papdaniel @Baoyuantop