-
Notifications
You must be signed in to change notification settings - Fork 2.7k
change: mark server-info plugin as deprecated
#12244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
server-info plugin as deprecated
|
@LiteSun please link the mailing list conversation in the pull request for reference on why it is being deprecated. |
done |
|
This is a change, not a feature, it modifies the default behavior. |
server-info plugin as deprecatedserver-info plugin as deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Block it for now until I have some free time to look at it more closely. Please don't merge it. 🫡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lack of transparency about several things:
- You mentioned
These frequent etcd writes may lead to performance degradation or even startup failures if etcd is not properly provisioned.
How to quantitatively assess the performance impact on etcd?
What specific parts are not configured correctly? I think it needs to be clearly stated how it should be done correctly. I think this might help users who are unable to upgrade and need to use the plugin.
- You mentioned
which is not a suitable use case for etcd and can lead to unnecessary system stress
APISIX does not register itself with external service discovery systems in any way, how does one know how to detect if an APISIX instance is alive or not, no one knows on which IP APISIX is running.
What are the alternatives? What alternative features will be introduced to compensate for the "issues" of the current removal, and if not, you need to explicitly mention "no" and welcome discussion on this.
- The deprecation process starts with the next release (i.e.
3.13.0), which is fine. But in your plan it will be removed at3.14.0, which is too soon, and the process requires more releases. Need to be more robust about these features that may have a larger sphere of influence.
An example is 553ac42. We introduced a new event broadcasting mechanism as the new default in 3.8.0, but the old implementation was not removed, the Users can switch it at any time via the configuration file. It remains in the code base for now.
We need to add more background information in the email thread and in this issue, and while this deprecation may not be a "discussion", it still needs to be transparent.
When does the issue occur: When APISIX is deployed in Recommended approach: If you need to continue using the
There is currently no perfect alternative. If you still need the information provided by the server-info plugin, you might consider developing a new plugin to store this data in a different backend such as Redis or MySQL. Alternatively, you can continue using the server-info plugin with caution, making sure that sufficient etcd hardware resources are provisioned.
If you feel the removal is too soon, we can postpone it by two additional release cycles to give users more time to adjust and discuss. Here’s the updated deprecation schedule:
Considering the uncertainty in APISIX's release cycle, this functionality will be officially deprecated no later than 6 months after the release of version 3.13.0. |
Description
mark
server-infoplugin as deprecated and update docsmailing list: https://lists.apache.org/thread/nrwqo1gbc0z4z48fkb8dd4rn0trnfnz9
Checklist