Skip to content

fix: original key being modified causing cache inconsistency #12299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

fix: original key being modified causing cache inconsistency #12299

merged 2 commits into from
Jun 10, 2025

Conversation

@Revolyssup
Copy link
Contributor

Fixes #
While calculating the value of the key, the current logic overrides the original key and stores the wrong key in the cache causing cache miss. This PR makes sure that original key is not modified.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jun 9, 2025
membphis
membphis approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^_^

@Revolyssup Revolyssup requested review from bzp2010 and moonming June 9, 2025 08:33
@moonming moonming merged commit 5aa842f into apache:master Jun 10, 2025
20 checks passed
@Revolyssup Revolyssup deleted the revolyssup/key-mod-bug branch June 10, 2025 04:16
Crazy-xyr pushed a commit to Crazy-xyr/apisix that referenced this pull request Jun 19, 2025
@Revolyssup
fix: original key being modified causing cache inconsistency (apache#…
5bc2ca0 
…12299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@membphis membphis membphis approved these changes

@nic-6443 nic-6443 nic-6443 approved these changes

@moonming moonming moonming approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees

No one assigned

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Revolyssup @membphis @nic-6443 @moonming