Skip to content

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Jun 25, 2025

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. chore labels Jun 25, 2025
CHANGELOG.md Outdated

### Change

- refactor(ai-proxy): move read_response into ai_driver.request function [#12101](https://github.com/apache/apisix/pull/12101)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem like a breaking change?

Copy link
Member

@kayx23 kayx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the items listed under "Change" seems to be breaking change.

CHANGELOG.md Outdated
### Change

- refactor(ai-proxy): move read_response into ai_driver.request function [#12101](https://github.com/apache/apisix/pull/12101)
- refactor: mcp server framework implementation #[12168](https://github.com/apache/apisix/pull/12168)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a refactoring of the mcp-bridge plugin #12151. It is not a breaking change for users. In the previous version, the plugin does not even exist.


- refactor(ai-proxy): move read_response into ai_driver.request function [#12101](https://github.com/apache/apisix/pull/12101)
- refactor: mcp server framework implementation #[12168](https://github.com/apache/apisix/pull/12168)
- change: mark server-info plugin as deprecated [#12244](https://github.com/apache/apisix/pull/12244)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not a breaking change as the plugin is not yet removed. Maybe you can put it under plugins section.

In the release notes on the website, I will make a deprecations section for this.

CHANGELOG.md Outdated
- refactor(ai-proxy): move read_response into ai_driver.request function [#12101](https://github.com/apache/apisix/pull/12101)
- refactor: mcp server framework implementation #[12168](https://github.com/apache/apisix/pull/12168)
- change: mark server-info plugin as deprecated [#12244](https://github.com/apache/apisix/pull/12244)
- feat(consumer): consumer username allows - in it [#12296](https://github.com/apache/apisix/pull/12296)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a feat not a change

CHANGELOG.md Outdated
- refactor: mcp server framework implementation #[12168](https://github.com/apache/apisix/pull/12168)
- change: mark server-info plugin as deprecated [#12244](https://github.com/apache/apisix/pull/12244)
- feat(consumer): consumer username allows - in it [#12296](https://github.com/apache/apisix/pull/12296)
- refactor: change log level to debug to avoid unnecessary logs [#12361](https://github.com/apache/apisix/pull/12361)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a breaking change for users?

CHANGELOG.md Outdated
- change: mark server-info plugin as deprecated [#12244](https://github.com/apache/apisix/pull/12244)
- feat(consumer): consumer username allows - in it [#12296](https://github.com/apache/apisix/pull/12296)
- refactor: change log level to debug to avoid unnecessary logs [#12361](https://github.com/apache/apisix/pull/12361)
- chore: change log level from warn to info for stale batch processor removal [#12297](https://github.com/apache/apisix/pull/12297)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a breaking change for users?

CHANGELOG.md Outdated
- feat(consumer): consumer username allows - in it [#12296](https://github.com/apache/apisix/pull/12296)
- refactor: change log level to debug to avoid unnecessary logs [#12361](https://github.com/apache/apisix/pull/12361)
- chore: change log level from warn to info for stale batch processor removal [#12297](https://github.com/apache/apisix/pull/12297)
- feat(standalone): allow more characters in credential_id for API-driven mode [#12295](https://github.com/apache/apisix/pull/12295)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API-driven mode is also new in this release and changes in this PR will not be breaking changes for users.

CHANGELOG.md Outdated
## Developer productivity

- feat: support devcontainer [11765](https://github.com/apache/apisix/pull/11765)
An Isolated environment from the host, the runtime and toolset required for APISIX development are built in the container build, they will be available out of the box and developers no longer need to build and install them on the host. Just start dev container, wait a few moments, and it's ready to go.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this paragraph (inconsistent formatting)? Additionally there are many grammatical errors.

Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls confirm this version no break change


```shell
APISIX_BRANCH='release/3.12.0'
APISIX_BRANCH='release/3.13.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inconsistent with the English documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Revolyssup They're still not the same. release/3.13 vs release/3.13.0

@bzp2010
Copy link
Contributor

bzp2010 commented Jun 27, 2025

@membphis

It contains break change. E.g., deprecate server-info

@Revolyssup
Copy link
Contributor Author

@membphis

It contains break change. E.g., deprecate server-info

Oh my apologies, I didn't count the deprecation in "breaking change". Fixed it.

membphis
membphis previously approved these changes Jun 27, 2025
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor issue

CHANGELOG.md Outdated
### Core

- feat(consumer): consumer username allows - in it [#12296](https://github.com/apache/apisix/pull/12296)
- refactor: change log level to debug to avoid unnecessary logs [#12361](https://github.com/apache/apisix/pull/12361)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a chore

Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the checklist in the PR description needs to be updated.


```shell
APISIX_BRANCH='release/3.12.0'
APISIX_BRANCH='release/3.13.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Revolyssup They're still not the same. release/3.13 vs release/3.13.0

@Revolyssup
Copy link
Contributor Author

APISIX_BRANCH='release/3.13.0

fixed

@Revolyssup Revolyssup merged commit cf65dcd into master Jun 27, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants