-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix: healthcheck manager missing runtime information #12607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: healthcheck manager missing runtime information #12607
Conversation
apisix/core.lua
Outdated
config = config, | ||
config_util = require("apisix.core.config_util"), | ||
sleep = utils.sleep, | ||
fetch_latest_conf = fetch_latest_conf, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my opinion:
create a new module
, it's name can be resource
then we can use it by call core.resource.get_nodes_ver
, what do you think? @Revolyssup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
apisix/core/config_util.lua
Outdated
return size | ||
end | ||
|
||
function _M.upstream_version(index, nodes_ver) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this function to upstream
lua module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. moved to utils/upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Solution:
Checklist