change(openid-connect): when bearer_only is false, require the user to fill in session.secret
#12609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
SkyeYoung
commented
Sep 12, 2025
nic-6443
approved these changes
Sep 12, 2025
bzp2010
approved these changes
Sep 12, 2025
SkyeYoung
changed the title
bearer_only is false, require the user to fill in session.secretbearer_only is false, require the user to fill in session.secret
SkyeYoung
deleted the
young/feat/openid-connect/error-msg-instead-of-generate-secret
branch
jizhuozhi
pushed a commit
to jizhuozhi/apisix
that referenced
this pull request
Oct 18, 2025
…er to fill in `session.secret` (apache#12609)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a part of #12603 and is separated out due to breaking changes.
Currently, the openid-connect plugin generates a random value for
conf.session.secretin thecheck_schemafunction when bothconditions: "
conf.bearer_onlyis false" and "conf.sessiondoes notexist" are met.
Modifying the user-provided configuration can easily lead to user
confusion, which is clearly not best practice.
This also affects the diff logic in the adc that the apisix ingress
controller depends on.
I believe this generation behavior should be removed. To solve this problem, This PR removed the corresponding code and
instead return an error message, requiring users to fill in the
corresponding configuration themselves.
Which issue(s) this PR fixes:
Fixes #
Checklist