-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix: correct handling of endpointSlices in Kubernetes service discovery #12634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChuanFF
wants to merge
32
commits into
apache:master
Choose a base branch
from
ChuanFF:endpoint-slices-feat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+742
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spelling error. post_List should be post_list
…int-slices-feat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Kubernetes service discovery implementation in APISIX incorrectly handles EndpointSlices, treating each individual slice as the complete set of endpoints for a service. This contradicts the official Kubernetes documentation.
According to the Kubernetes EndpointSlice documentation:
The correct behavior should be to combine all EndpointSlices sharing the same
kubernetes.io/service-name
label to form the complete endpoint set for a service.Solution Approach
1. Add EndpointSlices Cache
endpoint_slices_cache
to store all EndpointSlices with the structure:endpoint_slices_cache["k8s_id/namespace/k8s_service_name:port_name"] = {slice1, slice2, ...}
2. Code Refactoring
3. Some Bug Fixes
addresses
field: Theaddresses
field contains a list of IP strings, not objects with.ip
attributesendpoint_buffer
processing:endpoint_buffer
uses ports as keys and node lists as values, requiring only a single iteration level.Checklist