Skip to content

fix: add warning log when skipping check for disabled plugin #12655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2025
Merged

fix: add warning log when skipping check for disabled plugin #12655

merged 5 commits into from
Oct 9, 2025

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Oct 8, 2025 •
edited
Loading

Fixes #12626

Second approach from this comment is implemented. Please provide suggestions:
#12626 (comment)

First approach is breaking change.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Oct 8, 2025
@Revolyssup Revolyssup requested review from bzp2010 and membphis October 8, 2025 08:02
membphis
membphis previously approved these changes Oct 9, 2025
View reviewed changes
@Revolyssup Revolyssup requested a review from membphis October 9, 2025 08:19
bzp2010
bzp2010 approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@bzp2010 bzp2010 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great, but perhaps we should consider the first approach mentioned in the comments, giving people a choice to stop this absurd reality.

@Revolyssup Revolyssup merged commit 54eff28 into apache:master Oct 9, 2025
23 checks passed
@Revolyssup Revolyssup deleted the revolyssup/failsafe branch October 9, 2025 09:03
Revolyssup added a commit that referenced this pull request Oct 14, 2025
@Revolyssup
fix: add warning log when skipping check for disabled plugin (#12655)
d5bcf5c
jizhuozhi pushed a commit to jizhuozhi/apisix that referenced this pull request Oct 18, 2025
@Revolyssup @jizhuozhi
fix: add warning log when skipping check for disabled plugin (apache#…
ee69080 
…12655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@membphis membphis membphis approved these changes

@bzp2010 bzp2010 bzp2010 approved these changes

@nic-6443 nic-6443 nic-6443 approved these changes

@nic-chen nic-chen nic-chen approved these changes

Assignees

No one assigned

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

discuss: fail safe protection

5 participants

@Revolyssup @membphis @bzp2010 @nic-6443 @nic-chen