Skip to content

Conversation

SkyeYoung
Copy link
Member

@SkyeYoung SkyeYoung commented Oct 17, 2025

Description

Originally, the test of dashboard in cli used simulated files, which may not detect the real built dashboard's problems.

This PR is improved to use the real built dashboard directly to ensure the relevance of the issue and the dashboard.

At the same time, the check for static resource files svg has been added to better cover the needs of the dashboard.

Which issue(s) this PR fixes:

Fixes #

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@SkyeYoung SkyeYoung marked this pull request as ready for review October 17, 2025 03:44
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. chore labels Oct 17, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the admin UI test to use a real built dashboard instead of simulated test files. The change ensures better validation of the actual dashboard functionality by cloning and building the apisix-dashboard repository, then testing against real static assets instead of mock files.

Key changes:

  • Added build process to clone and compile the actual apisix-dashboard during tests
  • Enhanced test coverage to include SVG file accessibility checks
  • Replaced mock test files with real dashboard dist files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SkyeYoung SkyeYoung merged commit 06ee142 into apache:master Oct 21, 2025
31 of 34 checks passed
@SkyeYoung SkyeYoung deleted the young/test/use-dashboard-dist branch October 21, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants