Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go/adbc/driver/snowflake): implement WithTransporter driver option #2558

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

frbvianna
Copy link
Contributor

Relates to #2547

@frbvianna frbvianna marked this pull request as ready for review February 27, 2025 00:56
@github-actions github-actions bot added this to the ADBC Libraries 17 milestone Feb 27, 2025
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs some docstring comments and then i think we're good here!

@frbvianna frbvianna requested a review from zeroshade February 27, 2025 18:47
@frbvianna
Copy link
Contributor Author

@zeroshade added the docstrings, feel free to suggest any other enhancements. Thanks!

@zeroshade zeroshade merged commit 06308e4 into apache:main Feb 27, 2025
40 checks passed
@frbvianna frbvianna deleted the transporter branch February 27, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants