fix(ci): Prevent flaky ASAN failures with Dremio #2604
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
approved these changes
Mar 10, 2025
|
Seems we need to set more (maybe both CXX and CC have to be set?) |
|
I asked the Meson team about this on their IRC channel, and they mentioned that while gcc uses shared linkage to the ASAN runtime, clang requires static linkage to ASAN. It seems like something is awry with the latter, and it might have to do with how gtest is being used. I will have to investigate that further, or maybe see if there's a newer version of gcc that can be used instead of clang that still fixes the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per comment #2546 (comment) this might help fix the flaky CI failures with meson + ASAN