-
Notifications
You must be signed in to change notification settings - Fork 114
feat(go/adbc/driver/flightsql): Add OAuth Support to Flight Client #2651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
39da2c4
initial attempt. working with token exchange
xborder c10af80
add oauth support for flight client
xborder 7758432
add oauth tests
xborder bb8a1f1
add missing configurations to token exchange flow
xborder 10cd341
add missing configurations to client credentials
xborder 775e779
revert changes to example_usage_test
xborder 3f83c43
fix(go/adbc/driver/flightsql): tests linting
xborder e74fb32
fix(go/adbc/driver/flightsql): reset test suit db instead of server
xborder 823e6b8
chore(go/adbc/driver/flightsql): refactor set auth header to a function
xborder a0ad006
chore(go/adbc/driver/flightsql): refactor flightsql_oauth implementation
xborder 737e207
chore(go/adbc/driver/flightsql): small fixes
xborder 9ff438c
chore(go/adbc/driver/flightsql): moved token to flightsq configuration
xborder f8ce583
chore(go/adbc/driver/flightsql): fix token key
xborder 78fc5fc
chore(go/adbc/driver/flightsql): simplify setting token in SetOptions
xborder b1f4a4d
fix(go/adbc/driver/flightsql): throw error if triggering oauth but to…
xborder 1fc80e7
test(go/adbc/driver/flightsql): test to fail oauth if token is set
xborder 39693e2
chore(go/adbc): remove token as universal option
xborder 2a84059
chore(go/adbc/driver/flightsql): replace oauth impl
xborder a2b2fe3
test(go/adbc/driver/flightsql): adapt OAuth tests with tls
xborder bded2f0
chore(go/adbc/driver/flightsql): replace TokenSource with PerRPCCrede…
xborder 76fc327
chore(go/adbc/driver/flightsql): remove atoi
xborder 4d763b9
docs(source/driver): document oauth options
xborder ee56375
chore(go/adbc/driver/flightsql): simplification
xborder e7dc917
chore(go/adbc/driver/flightsql): code improvements
xborder 64b8143
fix(go/adbc/driver/flightsql): fix expected message
xborder 9e98498
docs(docs/source/driver): typo
xborder 9a665d0
docs(docs/source/driver): remove go only from docs
xborder c94f2ee
fix(go/adbc/driver/flightsql): small nits
xborder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it not Go only? Anything that uses the flightsql driver should be able to use the options that are being added. (We should add constants to the python
adbc_driver_flightsql
package)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to create a separate PR for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to make a separate PR to add the option constants, but I would still say that the "Go only" should be removed as nothing would prevent any other binding from using these options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.#2714