Skip to content

chore(r): Update CI setup to silence warnings for Go-based drivers #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Apr 15, 2025

Closes #2707.

This is more likely to be a change in Adbc somewhere since it's showing up in all versions. Did we add anything recently that logged anything to stderr or called assert or abort?

In the event it can't be avoided (it often can't), we can update the warning fail level for go-based drivers since we don't distribute them on CRAN.

@paleolimbot paleolimbot marked this pull request as ready for review April 15, 2025 03:23
@github-actions github-actions bot added this to the ADBC Libraries 18 milestone Apr 15, 2025
@lidavidm
Copy link
Member

This is more likely to be a change in Adbc somewhere since it's showing up in all versions. Did we add anything recently that logged anything to stderr or called assert or abort?

I don't think we did anything recently but I wouldn't be surprised if the Go runtime calls abort in some circumstances. I wonder if we could just interpose the symbol somehow to call R instead?

@paleolimbot
Copy link
Member Author

That sounds hard, but good to know there's an option! The driver packages have very little R code and so the WARNINGs aren't really catching anything anyway (the mostly likely thing that those checks are catching are things that will cause those drivers to stop building or loading, which would be ERRORs).

@paleolimbot paleolimbot merged commit 52312e5 into apache:main Apr 15, 2025
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r: check finds 'abort' and 'stderr' in Flight SQL driver
2 participants