feat(csharp/src/Drivers/Databricks): Implement telemetry tag definitions (phase 1) #3653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please make sure to have good PR descriptions |
| public TelemetryTagAttribute(string tagName) | ||
| { | ||
| TagName = tagName ?? throw new ArgumentNullException(nameof(tagName)); | ||
| ExportScope = TagExportScope.ExportAll; |
There was a problem hiding this comment.
How is this used? Why hardcode to ExportAll?
There was a problem hiding this comment.
defaulted to export local as discussed offline
| public const string DriverRuntime = "driver.runtime"; | ||
|
|
||
| // Feature Flags | ||
| [TelemetryTag("feature.cloudfetch", ExportScope = TagExportScope.ExportDatabricks, Description = "CloudFetch enabled")] |
There was a problem hiding this comment.
Are these only for Export to Databricks? Not local?
There was a problem hiding this comment.
updated to export all
sreekanth-db
commented
Oct 31, 2025
| /// <summary> | ||
| /// Gets tags allowed for Databricks export (privacy whitelist). | ||
| /// </summary> | ||
| // TODO: Explore alternate approaches to avoid maintaining separate GetDatabricksExportTags methods in each event class. |
There was a problem hiding this comment.
Added a todo comment to explore alternate approaches to GetDatabricksExportTags method (other than reflection), or changing the flow based on how we use this method (in the next phases)
jadewang-db
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Phase 1 of telemetry tag definitions (telemetry-activity-based-design.md) for the C# Databricks ADBC driver, establishing structured telemetry collection with privacy-aware export controls.
Changes
Introduces a declarative tag definition system across three telemetry event types:
1. Connection Events - Captures connection lifecycle and driver configuration
2. Statement Execution Events - Tracks query performance and resource usage
3. Error Events - Records error patterns and retry behavior
Export Scope Design
Tags use
TagExportScopeenum to control export destinations:ExportLocal- Sensitive data only (SQL, errors, addresses)ExportDatabricks- Only to databricks serviceExportAll- Non-sensitive operational metrics (both local & Databricks)TelemetryTagRegistryprovides centralized privacy filtering viaGetDatabricksExportTags()andShouldExportToDatabricks().Design Note: Added TODO comment acknowledging the current approach duplicates export scope between attributes and whitelist methods.
Testing
TelemetryTagRegistryTests)Next Steps
Future phases will add ActivityListener, metrics aggregator, and exporter components.