Skip to content

fix: restore 1.85 MSRV and fix MSRV CI#812

Open
LDeakin wants to merge 2 commits into
apache:mainfrom
LDeakin:fix/restore_1.85_MSRV
Open

fix: restore 1.85 MSRV and fix MSRV CI#812
LDeakin wants to merge 2 commits into
apache:mainfrom
LDeakin:fix/restore_1.85_MSRV

Conversation

@LDeakin

@LDeakin LDeakin commented Jul 21, 2026

Copy link
Copy Markdown

Closes #811

This just avoids using let chains, which were introduced in 1.88 or something.

@kylebarron kylebarron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@progval

progval commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

I also get this compilation error on 1.85:

error[E0599]: no function or associated item named `from_utf8` found for type `str` in the current scope
   --> src/parse.rs:477:25
    |
477 |         let body = str::from_utf8(&body).unwrap();
    |                         ^^^^^^^^^ function or associated item not found in `str`
    |
help: you are looking for the module in `std`, not the primitive type
    |
477 |         let body = std::str::from_utf8(&body).unwrap();
    |                    +++++

It's in a test, so not a big deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The 1.85 MSRV is inaccurate with all features

3 participants