Skip to content

Fix fonts in preview pages in forks - #710

Merged
ianmcook merged 1 commit into
apache:mainfrom
ianmcook:fonts
Sep 25, 2025
Merged

Fix fonts in preview pages in forks#710
ianmcook merged 1 commit into
apache:mainfrom
ianmcook:fonts

Conversation

@ianmcook

@ianmcook ianmcook commented Sep 25, 2025

Copy link
Copy Markdown
Member

The base URL of preview sites isn't the top of the domain, so these font files were not loading. This fixes it without causing any problems on the main deployed site.

@github-actions

Copy link
Copy Markdown

Preview URL: https://ianmcook.github.io/arrow-site

If the preview URL doesn't work, you may forget to configure your fork repository for preview.
See https://github.com/apache/arrow-site/blob/main/README.md#forks how to configure.

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've validated this fixes the issue on the fork (the font downloaded correctly) but I am curious as this is currently not failing on production, will this path change not affect the deployed site?

@ianmcook

Copy link
Copy Markdown
Member Author

Relative to this CSS file on the deployed site, / and ../ both mean the same thing, because the CSS file is nested one level deep. Relative paths in CSS are interpreted relative to the location of the CSS file itself, not the location of any pages that source it.

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sounds good to me

@ianmcook
ianmcook merged commit 374b8b0 into apache:main Sep 25, 2025
4 checks passed
@ianmcook
ianmcook deleted the fonts branch September 25, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants