-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Docs] Update implementation status for nanoarrow #45333
Conversation
docs/source/status.rst
Outdated
@@ -72,11 +72,11 @@ Data Types | |||
+-------------------+-------+-------+-------+----+-------+-------+-------+-------+-----------+ | |||
| Large Utf8 | ✓ | ✓ | ✓ | ✓ | \(4) | ✓ | ✓ | | ✓ | | |||
+-------------------+-------+-------+-------+----+-------+-------+-------+-------+-----------+ | |||
| Binary View | ✓ | | ✓ | | ✓ | ✓ | | | | | |||
| Binary View | ✓ | | ✓ | | ✓ | ✓ | | | ✓ | | |||
+-------------------+-------+-------+-------+----+-------+-------+-------+-------+-----------+ | |||
| Large Binary View | ✓ | | ✓ | | | | | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Large Binary View / Large Utf8 View exist? I couldn't see mention of this anywhere else in the codebase or flatbuffers spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so!
d9dfd7a
to
4e4ff7a
Compare
Looks like Decimal32/64 support was also added in apache/arrow-nanoarrow#683 by @zeroshade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
We also added ZSTD compression support to IPC and an IPC writer (but I forget if that's on the compatibility table).
4e4ff7a
to
45d498f
Compare
45d498f
to
0a9dd65
Compare
Updated to reflect the recent additions of list view / large list view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
Apologies if I was supposed to merge this before...do you have the merge script set up?
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d88ef57. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Binary view support was implemented in apache/arrow-nanoarrow#596 and run end encoded support was added in apache/arrow-nanoarrow#507
What changes are included in this PR?
Updated documentation
Are these changes tested?
N/A
Are there any user-facing changes?
No