Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Docs] Update implementation status for nanoarrow #45333

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Jan 22, 2025

Rationale for this change

Binary view support was implemented in apache/arrow-nanoarrow#596 and run end encoded support was added in apache/arrow-nanoarrow#507

What changes are included in this PR?

Updated documentation

Are these changes tested?

N/A

Are there any user-facing changes?

No

@WillAyd
Copy link
Contributor Author

WillAyd commented Jan 22, 2025

@paleolimbot

@@ -72,11 +72,11 @@ Data Types
+-------------------+-------+-------+-------+----+-------+-------+-------+-------+-----------+
| Large Utf8 | ✓ | ✓ | ✓ | ✓ | \(4) | ✓ | ✓ | | ✓ |
+-------------------+-------+-------+-------+----+-------+-------+-------+-------+-----------+
| Binary View | ✓ | | ✓ | | ✓ | ✓ | | | |
| Binary View | ✓ | | ✓ | | ✓ | ✓ | | | |
+-------------------+-------+-------+-------+----+-------+-------+-------+-------+-----------+
| Large Binary View | ✓ | | ✓ | | | | | | |
Copy link
Contributor Author

@WillAyd WillAyd Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Large Binary View / Large Utf8 View exist? I couldn't see mention of this anywhere else in the codebase or flatbuffers spec

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so!

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 23, 2025
@WillAyd WillAyd force-pushed the update-impl-status branch from d9dfd7a to 4e4ff7a Compare January 23, 2025 17:49
@WillAyd
Copy link
Contributor Author

WillAyd commented Jan 23, 2025

Looks like Decimal32/64 support was also added in apache/arrow-nanoarrow#683 by @zeroshade

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 23, 2025
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

We also added ZSTD compression support to IPC and an IPC writer (but I forget if that's on the compatibility table).

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Jan 23, 2025
@WillAyd WillAyd force-pushed the update-impl-status branch from 4e4ff7a to 45d498f Compare January 23, 2025 19:07
@WillAyd WillAyd force-pushed the update-impl-status branch from 45d498f to 0a9dd65 Compare March 6, 2025 17:44
@WillAyd
Copy link
Contributor Author

WillAyd commented Mar 6, 2025

Updated to reflect the recent additions of list view / large list view

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Apologies if I was supposed to merge this before...do you have the merge script set up?

@WillAyd WillAyd merged commit d88ef57 into apache:main Mar 6, 2025
7 checks passed
@WillAyd WillAyd removed the awaiting merge Awaiting merge label Mar 6, 2025
@WillAyd WillAyd deleted the update-impl-status branch March 6, 2025 20:32
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d88ef57.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants