GH-45362: [C++] Fix Identity cast for time scalar #45370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Windows CI failed seems to be related. |
mapleFU
force-pushed
the
GH-45362
branch
2 times, most recently
from
a615d7c to
22134a8
Compare
|
Also cc @pitrou since this is new year and @zanmato1984 might not have time for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #45362
What changes are included in this PR?
The pr #40237 introduce code:
However, the
Time64Type::TypeClassdoesn't exists, so SFINAE always failed.Are these changes tested?
Yes
Are there any user-facing changes?
bugfix
Time64ScalarandTime32Scalarfails #45362