WIP: [R] Verify CRAN release-20.0.0.1 #46472
Draft
+81
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the URLs is dead (https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.gz) and the sourceforge link is to the non-trimmed version. We are seeing these multiple downloads and fails on CRAN — I believe they get cleaned up so aren't the cause of those runners running out of space (See: https://www.r-project.org/nosvn/R.check/r-release-macos-x86_64/arrow-00install.txt and https://www.r-project.org/nosvn/R.check/r-oldrel-macos-x86_64/arrow-00install.html), but it still isn't great to have it download things we know will fail. ### Rationale for this change Don't download things we know will fail ### What changes are included in this PR? Removed two URLs ### Are these changes tested? Extensively. ### Are there any user-facing changes? No. * GitHub Issue: #40756 Authored-by: Jonathan Keane <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change Fix gcc-UBSAN CI job to be correctly running, then fix the UBSAN error. ### What changes are included in this PR? * Generalize our sanitizer jobs and use rhub's containers for this. wch/r-debug looks like it's out of date (hence why we didn't catch this), and it's easier to use a matrix of images with rhubarb anyway. * Initialize the `_quoted` variable — we could also cast it to boolean where the UBSAN popped, but this seems to be enough. ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: #46394 Authored-by: Jonathan Keane <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
|
@github-actions crossbow submit --group r |
github-actions
bot
added
Component: R
Component: C++
Component: Documentation
awaiting review
34 tasks
|
Revision: f5fa324 Submitted crossbow builds: ursacomputing/crossbow @ actions-37554312c9
|
|
Failures:
|
|
The binaries re-run ran successfully for the job that failed the first time, but it stumbled on artifacts. Rerunning the whole thing again: https://github.com/ursacomputing/crossbow/actions/runs/15071381698 |
|
Ah, wait not I think those failures are expected because we are building 20.0.0.1 and it's looking for 20.0.0 in the artifacts from github. It will download libarrow 20.0.0 in the relevant places and that's ok for us because they are compatible with each other. Does that sound right? Am I missing anything? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge this PR.
This PR is being used to prepare for the CRAN submission for 20.0.0.1
See packaging checklist: #46453