Skip to content

GH-46488 [C#] Switch to license expression #46624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-46488 [C#] Switch to license expression #46624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions csharp/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<Authors>The Apache Software Foundation</Authors>
<PackageIcon>feather.png</PackageIcon>
<!-- We can't use PackageLicenseExpression; the license file also contains 3rd-party notices. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you read this comment?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but when you review the third party notices, they are referring to the other languages ie cpp. At the same time on reviewing the source code, I couldn't find a source file which didn't have the Apache licence header or wasn't auto generated. Based on that it should be possible to move most if not all packages from the deprecated property to the replacement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the same time on reviewing the source code, I couldn't find a source file which didn't have the Apache licence header or wasn't auto generated.

How did you do it? Could you clarify it to clear our license?

BTW, we'll move csharp/ in apache/arrow to apache/arrow-dotnet: apache/arrow-dotnet#1

Can we work on this after it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you do it? Could you clarify it to clear our license?

I manually went through checking files in each of the projects including the sub folders.

BTW, we'll move csharp/ in apache/arrow to apache/arrow-dotnet: apache/arrow-dotnet#1

Can we work on this after it?

sure that is fine

<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
<PackageLicenseExpression>APACHE-2.0</PackageLicenseExpression>
<PackageProjectUrl>https://arrow.apache.org/</PackageProjectUrl>
<PackageTags>apache arrow</PackageTags>
<RepositoryType>git</RepositoryType>
Expand All @@ -55,7 +55,6 @@
</PropertyGroup>

<ItemGroup Condition="'$(IsPackable)' == 'true'">
<Content Include="$(RepoRoot)LICENSE.txt" Pack="true" PackagePath="" />
<Content Include="$(CSharpDir)/feather.png" Link="feather.png" Pack="true" PackagePath="\" />
</ItemGroup>

Expand Down