-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46746: [C++] Assume AWS SDK >= 1.11.0 #46742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
See also: |
@github-actions crossbow submit -g cpp -g python |
@github-actions crossbow submit wheelcp313* |
@github-actions crossbow submit -g r |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
CI failures are unrelated. |
@github-actions crossbow submit -g cpp -g python |
@github-actions crossbow submit wheelcp313* |
@github-actions crossbow submit -g r |
Revision: 9448f14 Submitted crossbow builds: ursacomputing/crossbow @ actions-fe91e15b58 |
Revision: 9448f14 Submitted crossbow builds: ursacomputing/crossbow @ actions-1ff451d45b |
Revision: 9448f14 Submitted crossbow builds: ursacomputing/crossbow @ actions-3f936fb3ce |
Oh, I had missed that our bundled version is still 1.10.55 (!). It was released in January 2023... |
I'm switching to draft until #45306 is merged. |
Rationale for this change
We're currently carrying compatibility code for AWS SDK before 1.9.0. However, we almost always bundled our own build of AWS SDK, so we should be able to rely on a more recent version. Version 1.11.0 was released in January 2023, which is already 2.5 years ago, so this should be a reasonable target.
This will make the S3 filesystem code more maintainable.
Are these changes tested?
Yes, on existing CI builds.
Are there any user-facing changes?
Users won't be able to build Arrow C++ if they have a very old version of the AWS SDK installed, unless they pass
-DAWSSDK_SOURCE=BUNDLED
.