-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47441: [Python][Parquet] Allow passing write_time_adjusted_to_utc to Python's ParquetWriter #47745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
2 similar comments
|
|
Hey @pitrou, I've exposed the UTC flag to the Python's Parquet API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update the docstrings as well (see _parquet_writer_arg_docs
)
We can indeed write a simple end-to-end test. Showing that the data roundtrips is IMHO sufficient. |
Thanks! |
I don't think so, no. |
|
Rationale for this change
Please see #47441 and #41476.
The
ArrowWriterProperties.write_time_adjusted_to_utc
flag is available in C++, yet isn't accessible from Python. This PR introduces the said flag to Python API as well.What changes are included in this PR?
Exposure of
use_time_adjusted_to_utc
boolean argument in Python's API.Are these changes tested?
Yes, roundtrip parquet tests for all combinations of time types and their respective time units.
Are there any user-facing changes?
The users will be able to adjust the said flag directly from Python API.
write_time_adjusted_to_utc
#47441