GH-47709 : [C++][FlightRPC] Return ODBC and data source information #47762
+1,585
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: rscales <[email protected]>
Add SQLGetInfo tests Co-Authored-By: rscales <[email protected]>
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
lidavidm
reviewed
Oct 9, 2025
| const bool is_unicode = true; | ||
|
|
||
| if (!info_value_ptr && !string_length_ptr) { | ||
| return static_cast<SQLRETURN> SQL_ERROR; |
There was a problem hiding this comment.
Suggested change
| return static_cast<SQLRETURN> SQL_ERROR; | |
| return static_cast<SQLRETURN>(SQL_ERROR); |
?
| // Driver Information | ||
|
|
||
| TYPED_TEST(FlightSQLODBCTestBase, TestSQLGetInfoActiveEnvironments) { | ||
| this->Connect(); |
There was a problem hiding this comment.
Could the connect/disconnect be put in a SetUp/TearDown?
Also it might not be wise to add the tests directly to FlightSQLODBCTestBase; could we create a fixture for this test suite specifically (by subclassing)?
github-actions
bot
added
awaiting changes
kou
reviewed
Oct 9, 2025
| TYPED_TEST(FlightSQLODBCTestBase, TestSQLGetInfoDriverName) { | ||
| this->Connect(); | ||
|
|
||
| Validate(this->conn, SQL_DRIVER_NAME, (SQLWCHAR*)L"Arrow Flight ODBC Driver"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ODBC needs to give BI tools information about the driver itself and the data source it is connected to.
What changes are included in this PR?
SQLGetinfoto return driver and data source informationget_info_cache.ccAre these changes tested?
Will be tested in CI when PR is ready for review
Are there any user-facing changes?
No