GH-46575: [C++][FlightRPC] ODBC Diagnostics Report #47763
Draft
+345
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
changed the title
|
|
alinaliBQ
force-pushed
the
gh-46575-odbc-diagnostics
branch
from
fe98d28 to
8d1b940
Compare
Co-Authored-By: rscales <[email protected]>
alinaliBQ
force-pushed
the
gh-46575-odbc-diagnostics
branch
from
8d1b940 to
0c8fddc
Compare
|
@lidavidm @kou Please review this draft ODBC API PR. The test PR is at #47764.
|
lidavidm
reviewed
Oct 9, 2025
| // The length of the sql state is always 5 characters plus null | ||
| SQLSMALLINT size = 6; | ||
| const std::string& state = diagnostics->GetSQLState(record_index); | ||
| GetStringAttribute(is_unicode, state, false, sql_state, size, &size, *diagnostics); |
There was a problem hiding this comment.
Do we not need to check the return value?
github-actions
bot
added
awaiting changes
kou
reviewed
Oct 9, 2025
| SQLSMALLINT* string_length_ptr, bool is_unicode) { | ||
| const SQLSMALLINT char_size = is_unicode ? GetSqlWCharSize() : sizeof(char); | ||
| const bool has_valid_buffer = | ||
| diag_info_ptr && buffer_length >= 0 && buffer_length % char_size == 0; |
There was a problem hiding this comment.
Do we need diag_info_ptr && here?
Suggested change
| diag_info_ptr && buffer_length >= 0 && buffer_length % char_size == 0; | |
| buffer_length >= 0 && buffer_length % char_size == 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ODBC needs to provide diagnostic information so users can debug the error
What changes are included in this PR?
Tests are included in separate PR (see GH-46575: [C++][FlightRPC] Add Diagnostic tests #47764)
Are these changes tested?
The build will be checked in CI when PR is ready for review.
Tests will be in a separate PR (see #47764). Other APIs depend on SQLGetDiagField and SQLGetDiagRec to get error reporting functionality, and tests for SQLGetDiagField and SQLGetDiagRec depend on other APIs for creating errors, as these diagnostic APIs alone do not initiate any errors.
Are there any user-facing changes?
No