GH-49595: [C++][FlightRPC] Linux ODBC deb installer support with CPack#49857
Draft
alinaliBQ wants to merge 3 commits intoapache:mainfrom
Draft
GH-49595: [C++][FlightRPC] Linux ODBC deb installer support with CPack#49857alinaliBQ wants to merge 3 commits intoapache:mainfrom
alinaliBQ wants to merge 3 commits intoapache:mainfrom
Conversation
Co-authored-by: vic-tsang <victor.tsang@improving.com> cpp/src/arrow/flight/sql/odbc/install/unix/install_odbc_ini.sh is originally authored by vic-tsang <victor.tsang@improving.com> Co-authored-by: justing-bq <justin.gossett@improving.com> for addressing feedback --------------------------------------- * Initial draft for macOS .pkg installer * in-progress for `install_odbc` * Remove `$HOME` from registration script * Generate .pkg installer and attempts to fix installer * Attempt to fix doc not seen * Attempt to fix ODBC registration script * Fix installer script and doc * Rename `install_odbc_ini.sh` to `postinstall` * Reuse `install_odbc.sh` script inside `postinstall` * Fix to generate macOS installer - Check $(pwd)/build/cpp * Clean up PR and todos * Update format to re-use code * Use `install_odbc_ini.sh` script to install DSN Keep a lightweight `postinstall` file for macOS * Update install_odbc_ini.sh execution access * Address Justin's comment Add timeout limit for macOS Address feedback
* Implement RPM installer fix formatting Remove todos ODBC rpm Installer wrap up * installing `rpm` package fixed the `cpack` command issue * Fix cpack command on CI (merge into last commit when ready) Change to use `awk` so script works on both platforms Comment out `find` and `tree` steps Change build path to be under /arrow Since docker is mounted, changing build path to be in `/arrow` will allow host machine to access docker build contents TEMP - Disable non-ODBC items Add commands to find build folder Attempt to build RPM installer * not sure if `/build/cpp` can be accessed outside of docker. Hopefully it should. * add `rpm` dependency install Indicate RPM in workflow run Add rpm `postinstall` (not tested) Remove merge conflict code * Enable ODBC installer build in CI instead of `compose.yaml` Update workflow matrix Update cpp_extra.yml Fix package name
|
|
github-actions
Bot
added
Component: C++
Component: FlightRPC
Component: Documentation
CI: Extra: C++
* Initial draft of DEB installer * reuse script for RPM, and rename script to indicate `postinst` (postinstall) * Add `file` to dockerfile to enable Debian installation * Fix component settings with DEB * Fix package name * Clean up comments * Fix file name * Fix postinst variable for DEB * Fix upload artifact file name and doc file name
alinaliBQ
force-pushed
the
gh-49595-deb-installer
branch
from
1e991ed to
875d9c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GH-49595
What changes are included in this PR?
This PR is dependent on #49787 to undraft and merge.
Add support for Linux ODBC
.debinstaller.Users can install with command:
The following contents will be installed by the
.debinstaller:Are these changes tested?
Yes, locally
Are there any user-facing changes?
Developers can download DEB installer from the CI.