GH-50993: [CI][Integration] Add extension-wrapped union to integration data - #51027
Open
Alb3e3 wants to merge 2 commits into
Open
GH-50993: [CI][Integration] Add extension-wrapped union to integration data#51027Alb3e3 wants to merge 2 commits into
Alb3e3 wants to merge 2 commits into
Conversation
…gration data Add a new integration datagen case (extension_union) with sparse- and dense-union columns wrapped in an extension type, so the cross-language integration tests exercise the extension/union interaction. This mirrors the C++ IPC coverage added in apacheGH-50623 (apache#50927).
|
|
The extension names in this case are not registered in the per-language integration binaries, so the C++ JSON reader (and others) rejected them with "Extension type not found". Flag them with ARROW:integration:allow_unregistered_extension so the extension metadata is preserved and the union storage is round-tripped by every implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Just as the C++ test suite gained coverage for extension-wrapped unions in #50927 (GH-50623), the cross-implementation integration tests should exercise this case so that every tested implementation handles an extension type whose storage is a union.
What changes are included in this PR?
A new archery integration datagen case,
extension_union, with two columns:sparse_union_ext: a sparse union (int32/utf8) wrapped in an extension typedense_union_ext: a dense union (int16/binary) wrapped in an extension typeExtensionFieldalready delegates its storage type/children/generation to the wrapped field, so no new datagen machinery is needed.Are these changes tested?
The generator produces valid integration JSON locally (schema carries the
ARROW:extension:*metadata on the union-typed fields, children preserved, batch sizes[0, 7]). The cross-implementation integration matrix in CI is the real test here — I've intentionally added the case with no per-implementation skips so the matrix can show which implementations still need a temporary.skip_tester(...); I'll add those (with tracking links) based on the results.Are there any user-facing changes?
No. This only adds integration-test data.
Closes #50993.