ARTEMIS-5694 CriticalCanalyzer to detect session.close timing out.#5952
Merged
Conversation
Contributor
Author
|
@brusdev I was looking into this with you.. I'm not sure yet what timeout to use.. or if I should always do this or upon configuration. But the test I wrote simulates the condition of pending forever on storage. and this would cleanup the situation if it happened. |
clebertsuconic
commented
Oct 3, 2025
clebertsuconic
commented
Oct 3, 2025
clebertsuconic
commented
Oct 3, 2025
clebertsuconic
force-pushed
the
closeSessions
branch
2 times, most recently
from
e02e44e to
82e7725
Compare
brusdev
reviewed
Oct 6, 2025
clebertsuconic
force-pushed
the
closeSessions
branch
3 times, most recently
from
7b15d87 to
03ee793
Compare
Contributor
Author
|
@brusdev can you review this? |
clebertsuconic
changed the title
clebertsuconic
force-pushed
the
closeSessions
branch
4 times, most recently
from
dffdb5c to
1ecf55c
Compare
brusdev
reviewed
Oct 6, 2025
clebertsuconic
force-pushed
the
closeSessions
branch
6 times, most recently
from
dcfc377 to
3f3d0a7
Compare
brusdev
reviewed
Oct 7, 2025
brusdev
left a comment
brusdev
left a comment
Member
There was a problem hiding this comment.
LGTM, I only added a few minor comments about the config?
Contributor
Author
|
I am converting this to a draft as I found a few scenarios where the lineupContext could be called without calling the actual storage.. (after exceptions) Also I will make this to use CriticalAnalyzer |
clebertsuconic
force-pushed
the
closeSessions
branch
3 times, most recently
from
280dbde to
e850ec5
Compare
clebertsuconic
force-pushed
the
closeSessions
branch
from
e850ec5 to
9326858
Compare
brusdev
reviewed
Oct 8, 2025
brusdev
left a comment
brusdev
left a comment
Member
There was a problem hiding this comment.
+1000 on using the Critical Analyzer
clebertsuconic
force-pushed
the
closeSessions
branch
from
1e01c08 to
92e09e2
Compare
clebertsuconic
force-pushed
the
closeSessions
branch
6 times, most recently
from
1538556 to
1777279
Compare
Also fixing a few cases where a context would hang
clebertsuconic
force-pushed
the
closeSessions
branch
from
1777279 to
58cf638
Compare
clebertsuconic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.