Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of jobs mutex in prism server and prevent race conditions in artifacts map. #32657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeremyje
Copy link
Contributor

@jeremyje jeremyje commented Oct 4, 2024

Resolves #32656

This change adds a mutex to the artifacts variable in the grpc server for the jobservices in the Prism runner within the Go SDK. In general, maps in Go are not thread safe so 2 concurrent grpc requests that read/write from any of the handlers, notably /ArtifactRetrievalService.ResolveArtifacts /ArtifactStagingService.ReverseArtifactRetrievalService handlers will trigger a race condition. This generally is not visible unless you have a test with the race detector enabled.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Go Prism Runner Concurrent Map Mutations
1 participant