[Java] Add Gauge Metric Extraction to DataflowMetrics #34307
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @lostluck added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
assign to next reviewer |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damondouglas added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @damondouglas |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @damondouglas added as fallback since no labels match configuration Available commands:
|
|
I need to be removed from the fallback list, but for now, let me ping @kennknowles or @robertwb to take a look at this. IIRC Dataflow doesn't actually support Gauge metrics, so there wouldn't be any to extract... |
|
R: @Naireen |
| if (metricUpdate.getGauge() == null) { | ||
| return GaugeResult.empty(); | ||
| } | ||
| Object gaugeValue = metricUpdate.getGauge(); |
There was a problem hiding this comment.
@Naireen please take a look
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Please add a meaningful description for your change here
This PR addresses issue #33448, where gauge metrics were not being extracted into the metrics results in the Dataflow runner, preventing users from querying them programmatically. The root cause was that
DataflowMetrics.DataflowMetricResultExtractor.addMetricResultdid not handle gauge metrics fromMetricUpdateobjects returned by the Dataflow API.Closes #33448
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.