Skip to content

ML benchmark pipelines #34361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Conversation

Amar3tto
Copy link
Collaborator

@Amar3tto Amar3tto commented Mar 20, 2025

  • Improved dataflow_cost_benchmark.py
    • Getting Throughput metrics
    • Getting RunTime metrics
  • Updated Beam Website
    • Added ML pipelines metrics for
      • 5 PyTorch pipelines with diagrams
      • 1 TensorFlow pipeline with diagrams
  • Updated Looker graphs ids and links

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Amar3tto
Copy link
Collaborator Author

Amar3tto commented Mar 20, 2025

Going to fix PythonFormatter and other checks

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 71 lines in your changes missing coverage. Please review.

Project coverage is 56.36%. Comparing base (5d38b8e) to head (e7417b1).
Report is 97 commits behind head on master.

Files with missing lines Patch % Lines
...beam/testing/load_tests/dataflow_cost_benchmark.py 0.00% 64 Missing ⚠️
...ference/pytorch_image_classification_benchmarks.py 0.00% 3 Missing ⚠️
.../inference/pytorch_language_modeling_benchmarks.py 0.00% 2 Missing ⚠️
.../tensorflow_mnist_classification_cost_benchmark.py 0.00% 1 Missing ⚠️
...che_beam/testing/benchmarks/wordcount/wordcount.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #34361      +/-   ##
============================================
+ Coverage     56.32%   56.36%   +0.04%     
  Complexity     3286     3286              
============================================
  Files          1172     1174       +2     
  Lines        178933   179323     +390     
  Branches       3398     3398              
============================================
+ Hits         100778   101071     +293     
- Misses        74898    74995      +97     
  Partials       3257     3257              
Flag Coverage Δ
python 81.26% <0.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm
Copy link
Contributor

R: @jrmccluskey

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Amar3tto Amar3tto requested a review from jrmccluskey March 21, 2025 06:00
Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM on the python side, just a minor typo + a question around a type hint change

@Amar3tto Amar3tto force-pushed the ml-benchmark-pipelines branch from f051f3e to d94e54b Compare March 26, 2025 14:28
@Amar3tto Amar3tto requested a review from jrmccluskey March 26, 2025 15:44
Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jrmccluskey jrmccluskey merged commit 0766593 into apache:master Mar 26, 2025
95 checks passed
liferoad pushed a commit to liferoad/beam that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants