Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Prism on handling empty and identity transforms #34566

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Prism on handling empty and identity transforms #34566

wants to merge 4 commits into from

Conversation

shunping
Copy link
Collaborator

@shunping shunping commented Apr 7, 2025

addresses #34564

@shunping shunping requested a review from lostluck April 7, 2025 18:16
lostluck
lostluck reviewed Apr 7, 2025
View reviewed changes
sdks/go/pkg/beam/runners/prism/internal/preprocess.go Outdated
inputID := getOnlyValue(t.GetInputs())
outputID := getOnlyValue(t.GetOutputs())
if inputID == outputID {
shouldAdd = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use continue here instead of adding a boolean to set and check. Reduces the cyclomatic complexity of the surrounding code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions bot added python and removed python labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostluck lostluck lostluck left review comments

Assignees
No one assigned
Labels
go Next Action: Reviewers prism runners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunping @lostluck