Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pickling top-level enums. #34568

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

claudevdm
Copy link
Collaborator

@claudevdm claudevdm commented Apr 7, 2025

#21298

This handles pickling of enums that are defined at the top level

A top level enum is defined like

enum Enum {
  UNSPECIFIED = 0;

  // Event time is time from the perspective of the data
  EVENT_TIME = 1;
}
A nested enum is defined like
message TimeDomain {
  enum Enum {
    UNSPECIFIED = 0;

    // Event time is time from the perspective of the data
    EVENT_TIME = 1;

  }
}

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Apr 7, 2025
@claudevdm
Copy link
Collaborator Author

R: @tvalentyn

@claudevdm claudevdm marked this pull request as ready for review April 7, 2025 20:40
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@claudevdm
Copy link
Collaborator Author

I could not find any top level proto enums to use for writing a unit test, let me know if I should create some fake protos for test coverage?

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test that exercises this?. nvm, just saw the comment above

@claudevdm
Copy link
Collaborator Author

Do we have a test that exercises this?. nvm, just saw the comment above

Just added tests and regenerated the proto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants