More eagerly merge compatible environments. #34583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, merge environments that are identical except for their dependencies, but where one environment's dependencies are a superset of the others. This will reduce the number of distinct environments of the same type, and the associated materialization costs of moving between them. Ideally this would be done in a runner for environments that are already co-located on the same worker, but that is a further optimization.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
As well as being very different from the low-level execution details found in common.py, there is no need to compile these (whereas the other structures in common.py are critical to optimize for elementwise efficiency).
|
Assigning reviewers. If you would like to opt out of this review, comment R: @claudevdm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
claudevdm
approved these changes
Apr 9, 2025
| with tempfile.TemporaryDirectory() as tmpdir: | ||
|
|
||
| def make_file(basename, content): | ||
| subdir = tempfile.TemporaryDirectory(dir=tmpdir, delete=False).name |
There was a problem hiding this comment.
Looks like a test is failing because of delete=False. Maybe use tempfile.NamedTemporaryFile?
def make_file(basename, content):
> subdir = tempfile.TemporaryDirectory(dir=tmpdir, delete=False).name
E TypeError: __init__() got an unexpected keyword argument 'delete'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, merge environments that are identical except for their dependencies, but where one environment's dependencies are a superset of the others.
This will reduce the number of distinct environments of the same type, and the associated materialization costs of moving between them.
Ideally this would be done in a runner for environments that are already co-located on the same worker, but that is a further optimization.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.