Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cached prism binary without re-unzipping by default. #34616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shunping
Copy link
Collaborator

@shunping shunping commented Apr 12, 2025

Previously, when we have cache enabled for prism binary/zip and both binary and zip file in cache, PrismJobServer will still unzip the prism zip file. This leads to the error of Text file busy when we try to run a prism runner the second time in colab (#33623 (comment)).

This PR fixes this problem and adds an array of unit tests.

addresses #33623

Notice that there is another problem in the original issue regarding running the prism runner multiple times results in multiple prism processes in colab. There will be a follow-up PR (#34623) for that.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping shunping force-pushed the prism-bug-in-colab branch from bddda91 to f55e2ce Compare April 13, 2025 05:08
@shunping shunping requested a review from liferoad April 14, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant