[WIP] Update Error Prone for ThreadSafe analysis #34861
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Error Prone and Error Prone Gradle plugin versions. Error Prone 2.19.0 introduced a thread safety checker (compatible with Error Prone's
@ThreadSafeannotation) which provides a few automated checks based on e.g.@GuardedByannotations.This should help catch obvious thread safety issues in annotated code undergoing maintenance/refactoring.
Error Prone's minimum supported compiler release was bumped from 8 to 11 between 2.10.0 and 2.19.0 and from 11 to 17 between 2.19.0 and 2.38.0. Additionally, Beam now fails to build because of new, updated and fixed checkers. This PR should address compiler (17+) and target release (8+) versioning requirements (e.g. using Gradle toolchains or
--releaseflag) and silence new Error Prone warnings (e.g. by temporarily disabling or fixing issues). Note thatThreadSafeCheckeris published, but not supported in any current release of Error Prone (google/error-prone#4833).This PR might take a while, but hopefully makes these changes easier to manage going forward.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.