-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add filter to GetMinUnfinishedWatermark query #34965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6dd1c39
to
e77b86a
Compare
f5020d9
to
65aa1eb
Compare
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
2deda7c
to
7cc7fcc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34965 +/- ##
=============================================
+ Coverage 54.50% 68.65% +14.15%
Complexity 1479 1479
=============================================
Files 1012 194 -818
Lines 160667 8111 -152556
Branches 1079 1079
=============================================
- Hits 87573 5569 -82004
+ Misses 70991 2158 -68833
+ Partials 2103 384 -1719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
7cc7fcc
to
9292d51
Compare
To improve the performance of the query for GetUnfinishedMinWatermark, we can add a filter to the query.
Note that the query run on a cache to refresh every 1s. We can remember the cached value every time and use the value as a filter in the next time query.