Skip to content

Add filter to GetMinUnfinishedWatermark query #34965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

changliiu
Copy link
Contributor

@changliiu changliiu commented May 15, 2025

To improve the performance of the query for GetUnfinishedMinWatermark, we can add a filter to the query.
Note that the query run on a cache to refresh every 1s. We can remember the cached value every time and use the value as a filter in the next time query.

@changliiu changliiu force-pushed the add-watermark-filter branch 2 times, most recently from 6dd1c39 to e77b86a Compare May 15, 2025 23:20
@changliiu changliiu changed the title add filter to watermark query Add filter to GetMinUnfinishedWatermark query May 15, 2025
@changliiu changliiu marked this pull request as ready for review May 15, 2025 23:32
@changliiu changliiu force-pushed the add-watermark-filter branch 2 times, most recently from f5020d9 to 65aa1eb Compare May 15, 2025 23:38
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.65%. Comparing base (bea0444) to head (7cc7fcc).
Report is 39 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #34965       +/-   ##
=============================================
+ Coverage     54.50%   68.65%   +14.15%     
  Complexity     1479     1479               
=============================================
  Files          1012      194      -818     
  Lines        160667     8111   -152556     
  Branches       1079     1079               
=============================================
- Hits          87573     5569    -82004     
+ Misses        70991     2158    -68833     
+ Partials       2103      384     -1719     
Flag Coverage Δ
go ?
java 68.65% <ø> (+0.01%) ⬆️
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Assigning reviewers:

R: @shunping for label python.
R: @m-trieu for label java.
R: @Abacn for label build.
R: @fozzie15 for label kafka.
R: @nielm for label spanner.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@changliiu changliiu marked this pull request as draft May 22, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant