Skip to content

Add warning if temp location bucket has soft delete enabled for Go SD… #34996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TanuSharma2511
Copy link
Contributor

…K (resolves #31606 )

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 56.45%. Comparing base (28df7cb) to head (e112886).
Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
sdks/go/pkg/beam/runners/dataflow/dataflow.go 40.00% 10 Missing and 2 partials ⚠️
sdks/go/pkg/beam/util/gcsx/gcs.go 23.07% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #34996      +/-   ##
============================================
+ Coverage     54.54%   56.45%   +1.90%     
- Complexity     1479     3300    +1821     
============================================
  Files          1011     1182     +171     
  Lines        160536   181468   +20932     
  Branches       1079     3409    +2330     
============================================
+ Hits          87561   102441   +14880     
- Misses        70874    75755    +4881     
- Partials       2101     3272    +1171     
Flag Coverage Δ
go 28.20% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Assigning reviewers:

R: @shunping for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@TanuSharma2511
Copy link
Contributor Author

@shunping let me know if I need to add unit test for checkSoftDeletePolicyEnabled in dataflow_test.go. If this is the case, I did not find any existing mock bucket code. Please let me know If I need to create it myself.

@TanuSharma2511
Copy link
Contributor Author

@shunping requesting your review here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add warning if temp location bucket has soft delete enabled for Go SDK.
1 participant