-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-9917] Document BigQuery file load behavior with dynamic destinations #37108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[BEAM-9917] Document BigQuery file load behavior with dynamic destinations #37108
Conversation
Summary of ChangesHello @Vaishnavi-Pandey12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Apache Beam documentation by adding a crucial clarification regarding the behavior of BigQuery file load-based writes. It highlights a known limitation where using dynamic destinations in conjunction with a non-zero Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Assigning reviewers: R: @damccorm for label website. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| > **Note:** When using file load-based BigQuery writes with dynamic destinations and a non-zero | ||
| > `triggering_frequency`, temporary tables may be created repeatedly and loads | ||
| > are not finalized into destination tables. This is a known limitation (see BEAM-9917). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the goal of this issue (#20242) is to resolve the root cause not documenting the issue/bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification — that makes sense.
I added the documentation note to clarify the current behavior while
investigating the issue, but I understand that the primary goal is to
address the root cause.
As a next step, I can add a failing unit test that captures the current
behavior with dynamic destinations and triggering_frequency, or help
with investigation into the finalization logic. Please let me know which
direction would be preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can reproduce this issue locally, we are halfway towards the resolution. A reproducibility experiment can be something along those lines:
- We can see where
BigQueryBatchFileLoadsis located in the codebase (using keyword-based search in the IDE) - Once we know where it is located, we can see how it has been tested e.g with single table/multiple tables
- If there are tests for multiple tables, we can see if there are ongoing residual temporary tables (as mentioned in the issue)
- If there are no tests for multiple tables or not feasible to be integration-tested, we can test it with a free tier version of our real GCP
Once we can reproduce that issue, we can see the relevant codepaths and start to tweak them intentionally with relevant tests so that issue doesn't happen again as a regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a next step, I can add a failing unit test that captures the current
behavior with dynamic destinations and triggering_frequency, or help
with investigation into the finalization logic. Please let me know which
direction would be preferred.
It would be great if we could have a reproducible test that captures the bug first, then we can iterate on the solution
This PR adds a small documentation note clarifying the current behavior of
file load-based BigQuery writes when used with dynamic destinations and a
non-zero triggering_frequency.
Issue: BEAM-9917
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.