Skip to content

Conversation

@Vaishnavi-Pandey12
Copy link

This PR adds a small documentation note clarifying the current behavior of
file load-based BigQuery writes when used with dynamic destinations and a
non-zero triggering_frequency.

Issue: BEAM-9917


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Vaishnavi-Pandey12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Apache Beam documentation by adding a crucial clarification regarding the behavior of BigQuery file load-based writes. It highlights a known limitation where using dynamic destinations in conjunction with a non-zero triggering_frequency can result in temporary tables being repeatedly created and loads not being finalized into their intended destination tables. This update aims to provide users with better guidance and awareness of this specific operational caveat within the BigQuery IO connector.

Highlights

  • Documentation Update: Added a critical note to the BigQuery IO documentation clarifying a known limitation related to file load-based BigQuery writes.
  • BigQuery Write Behavior: The note specifically addresses the scenario where dynamic destinations are used with a non-zero triggering_frequency, leading to repeated temporary table creation and unfinalized loads (BEAM-9917).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @damccorm for label website.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Comment on lines +663 to +665
> **Note:** When using file load-based BigQuery writes with dynamic destinations and a non-zero
> `triggering_frequency`, temporary tables may be created repeatedly and loads
> are not finalized into destination tables. This is a known limitation (see BEAM-9917).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the goal of this issue (#20242) is to resolve the root cause not documenting the issue/bug?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification — that makes sense.

I added the documentation note to clarify the current behavior while
investigating the issue, but I understand that the primary goal is to
address the root cause.

As a next step, I can add a failing unit test that captures the current
behavior with dynamic destinations and triggering_frequency, or help
with investigation into the finalization logic. Please let me know which
direction would be preferred.

Copy link
Contributor

@mohamedawnallah mohamedawnallah Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can reproduce this issue locally, we are halfway towards the resolution. A reproducibility experiment can be something along those lines:

  • We can see where BigQueryBatchFileLoads is located in the codebase (using keyword-based search in the IDE)
  • Once we know where it is located, we can see how it has been tested e.g with single table/multiple tables
  • If there are tests for multiple tables, we can see if there are ongoing residual temporary tables (as mentioned in the issue)
  • If there are no tests for multiple tables or not feasible to be integration-tested, we can test it with a free tier version of our real GCP

Once we can reproduce that issue, we can see the relevant codepaths and start to tweak them intentionally with relevant tests so that issue doesn't happen again as a regression

Copy link
Contributor

@mohamedawnallah mohamedawnallah Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a next step, I can add a failing unit test that captures the current
behavior with dynamic destinations and triggering_frequency, or help
with investigation into the finalization logic. Please let me know which
direction would be preferred.

It would be great if we could have a reproducible test that captures the bug first, then we can iterate on the solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants