Fix empty stream name encountered in StorageApiFinalizeWrtiesDoFn#38410
Fix empty stream name encountered in StorageApiFinalizeWrtiesDoFn#38410Abacn wants to merge 1 commit into
Conversation
|
I don't really understand this PR - can you explain it? The initializeContext/clearContexts structure is the one that has been there for a very long time, so I'm not sure why you're changing it. |
| } | ||
|
|
||
| // Re-establish the client with the new stream. | ||
| clearClients.accept(failedContexts); |
There was a problem hiding this comment.
clearClients no longer even looks at failedContexts. We should simplify it and remove the parameter
There was a problem hiding this comment.
We should probably rename clearClients to resetClient
Yeah agree that this part sounds less relevant. This is just an AI-assistent attempt and it doesn't look clear to me either. It's just for reference. The part that moves |
Follow up #38264
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.