Skip to content

Fix iceberg gcs dependency after gcsio 3.0 upgrade#38488

Open
Abacn wants to merge 1 commit into
apache:masterfrom
Abacn:fix-iceberg-sql-test
Open

Fix iceberg gcs dependency after gcsio 3.0 upgrade#38488
Abacn wants to merge 1 commit into
apache:masterfrom
Abacn:fix-iceberg-sql-test

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented May 13, 2026

Please add a meaningful description for your change here

Follow up #38419, it appears bigdataoss_util_hadoop no longer present in runtime classpath for the test, causing

errors like Caused by: org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme "gs"


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn Abacn force-pushed the fix-iceberg-sql-test branch from c84da86 to be39171 Compare May 13, 2026 17:45
@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented May 13, 2026

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented May 13, 2026

R: @Amar3tto

@Abacn Abacn marked this pull request as ready for review May 13, 2026 17:46
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses runtime classpath issues introduced by the gcsio 3.0 upgrade. By explicitly including the necessary Hadoop utility dependencies for GCS, it ensures that the Iceberg integration can correctly identify and utilize the required file system implementations during test execution and runtime.

Highlights

  • Dependency Resolution: Added bigdataoss_util_hadoop as a runtime dependency to resolve 'UnsupportedFileSystemException' errors related to GCS file system access.
  • Iceberg Configuration: Updated the expansion service build configuration to include Iceberg dependencies unconditionally, removing the previous Java version-based conditional check.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a trigger file, adds a Hadoop utility dependency to the Iceberg SQL extension, and removes a Java version guard for Iceberg dependencies in the expansion service. The reviewer identified that removing the Java 8 compatibility check for Iceberg dependencies will cause an UnsupportedClassVersionError in Java 8 environments, as Iceberg 1.7.0+ requires Java 11. It is recommended to restore the guard and include the new Hadoop dependency within it.

Comment thread sdks/java/io/expansion-service/build.gradle
@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented May 13, 2026

R: @Amar3tto also need to cherry-pick this into the release branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant