chore: remove assert statement in LedgerDescriptor (#4334)

Signed-off-by: ZhangJian He <[email protected]>

Author: hezhangjian

bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java

@@ -40,10 +40,10 @@
 public class LedgerDescriptorImpl extends LedgerDescriptor {
     private static final Logger LOG = LoggerFactory.getLogger(LedgerDescriptorImpl.class);
     final LedgerStorage ledgerStorage;
-    private long ledgerId;
+    private final long ledgerId;
     final byte[] masterKey;
 
-    private AtomicBoolean fenceEntryPersisted = new AtomicBoolean();
+    private final AtomicBoolean fenceEntryPersisted = new AtomicBoolean();
     private CompletableFuture<Boolean> logFenceResult = null;
 
     LedgerDescriptorImpl(byte[] masterKey,

bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorReadOnlyImpl.java

@@ -34,19 +34,16 @@ public class LedgerDescriptorReadOnlyImpl extends LedgerDescriptorImpl {
 
     @Override
     boolean setFenced() throws IOException {
-        assert false;
         throw new IOException("Invalid action on read only descriptor");
     }
 
     @Override
     long addEntry(ByteBuf entry) throws IOException {
-        assert false;
         throw new IOException("Invalid action on read only descriptor");
     }
 
     @Override
     void checkAccess(byte[] masterKey) throws BookieException, IOException {
-        assert false;
         throw new IOException("Invalid action on read only descriptor");
     }
 }