Skip to content

Improve release script instructions #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 21, 2024
Merged

Improve release script instructions #4236

merged 6 commits into from
Mar 21, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Mar 20, 2024 •
edited
Loading

Motivation

While testing the dev/release/000-run-docker.sh I ran into several problems.

  • My ~/.gitconfig settings collided with the configuration used in 000-run-docker.sh
    • I'm using GitHub CLI gh auth login to manage git credentials for GitHub
  • The git commit failed because of some unsafe directory warning
  • gpg-agent failed to run and gpg signing failed

Changes

  • add more instructions when the script starts
  • add workaround for gpg-agent and gpg issue

@lhotari
Copy link
Member Author

lhotari commented Mar 20, 2024

@eolivelli @nicoloboschi here's another one to fix issues I faced with the release script

@lhotari lhotari mentioned this pull request Mar 21, 2024
Merged
eolivelli
eolivelli approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nicoloboschi nicoloboschi merged commit 47bf54d into apache:master Mar 21, 2024
20 checks passed
nicoloboschi pushed a commit that referenced this pull request Mar 21, 2024
@lhotari @nicoloboschi
Improve release script instructions (#4236)
222f42a
eolivelli pushed a commit that referenced this pull request Mar 25, 2024
@lhotari @eolivelli
Improve release script instructions (#4236)
1f43f2c 
(cherry picked from commit 47bf54d)
lhotari added a commit that referenced this pull request Jun 13, 2024
@lhotari
Improve release script instructions (#4236)
feae0b1 
(cherry picked from commit 222f42a)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@lhotari
Improve release script instructions (apache#4236)
b3c7a15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@nicoloboschi nicoloboschi nicoloboschi approved these changes

Assignees
No one assigned
Labels
cherry-picked/branch-4.15 cherry-picked/branch-4.16 release/4.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhotari @eolivelli @nicoloboschi