Issue 4503: Added check into BufferedChannel's read to avoid endless loop #4506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… buffer's remaining capacity is not as much as length
|
Thanks for your contribution. Could you please add a unit test for this change? |
|
Of course, I will add test cases to the existing BufferedChanelTests |
hezhangjian
approved these changes
Sep 19, 2024
xiezhx9
approved these changes
Sep 21, 2024
|
Hi, some time has passed since this pr opened and I recall that CI error was due to unability of wget to download a bk tar (maybe some backward compat tests) compressed archive from apache.org, just saying to allow you to rerun CI and then close this PR |
|
reopen's reason: rerun failure checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4503
Motivation
As discussed in the referred issue, this PR aims to avoid the endless loop which will happen if the dest ByteBuf passed to the BufferedChannel's read has less remaining writable bytes than the amount of bytes required to read (read's "length" parameter)
Changes
Now, BufferedChannel.read() throws an exception if dest. buf. writableBytes is less than length