Skip to content

Set ThreadFactory for Executor in EntryLoggerAllocator #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2025
Merged

Set ThreadFactory for Executor in EntryLoggerAllocator #4562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb8305f
Set ThreadFactory for Executor in EntryLoggerAllocator
Shawyeok Mar 6, 2025
0815d94
Address checkstyle violation
Shawyeok Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLoggerAllocator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import io.netty.buffer.ByteBuf;
import io.netty.buffer.ByteBufAllocator;
import io.netty.buffer.Unpooled;
import io.netty.util.concurrent.DefaultThreadFactory;
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileOutputStream;
Expand Down Expand Up @@ -76,7 +77,8 @@ class EntryLoggerAllocator {
this.preallocatedLogId = logId;
this.recentlyCreatedEntryLogsStatus = recentlyCreatedEntryLogsStatus;
this.entryLogPreAllocationEnabled = conf.isEntryLogFilePreAllocationEnabled();
this.allocatorExecutor = Executors.newSingleThreadExecutor();
this.allocatorExecutor = Executors.newSingleThreadExecutor(
new DefaultThreadFactory("EntryLoggerAllocator"));

// Initialize the entry log header buffer. This cannot be a static object
// since in our unit tests, we run multiple Bookies and thus EntryLoggers
Expand Down